Support rename=True in collections.namedtuple #17247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pretty marginal feature but it's now tested in the typing conformance suite, and it was easy to add support.
for more information, see https://pre-commit.ci
JelleZijlstra
commented
May 15, 2024
| @@ -125,6 +128,8 @@ E = namedtuple('E', 'a b', 0) | |||
| [builtins fixtures/bool.pyi] | |||
|
|
|||
| [out] | |||
| main:4: error: Boolean literal expected as the "rename" argument to namedtuple() | |||
| main:5: error: Boolean literal expected as the "rename" argument to namedtuple() | |||
There was a problem hiding this comment.
A little unfortunate that we give two errors for the same line, but the same happens with T = TypeVar("T", covariant="True"); I don't think it's worth the effort to suppress one of the two.
There was a problem hiding this comment.
I think its fine to keep both errors but it would be better if both errors have the same code so that they can be disabled with a single type ignore comment. Currently the errors are:
nt.py:5: error: Boolean literal expected as the "rename" argument to namedtuple() [misc]
nt.py:5: error: Argument "rename" to "namedtuple" has incompatible type "str"; expected "bool" [arg-type]
How about giving the first error the code arg-type as well?
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hamdanal
approved these changes
May 18, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pretty marginal feature but it's now tested in the typing conformance suite,
and it was easy to add support.
For reference: https://github.com/python/typing/blob/9f7f400bb7c4c79f1fb938402e0bb3198dac0054/conformance/tests/namedtuples_define_functional.py#L46, https://github.com/python/cpython/blob/7d8725ac6f3304677d71dabdb7c184e98a62d864/Lib/collections/__init__.py#L389